Some good bits of advice here including:
– choose your battles wisely
– bear in mind that there are things that neither you or your boss has control over that affect the work environment
– avoid being negative/try to bring solutions
And if you need a refresher on the “why bother” element of giving your boss feedback, you can check out this piece that I wrote a while back.